Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedded Tor v0.4.7.x #64

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

mibmo
Copy link
Contributor

@mibmo mibmo commented Jun 11, 2022

Passes tests and seems to work just fine, but it'd be nice if someone would independently verify.
It's essentially just a copy of the Tor v0.3.5.x implementation, but search-and-replaced.

For tests in cretz/tor-static#36 and MacOS support in cretz/tor-static#35.

@cretz
Copy link
Owner

cretz commented Jun 13, 2022

This looks great, thanks! I assume the embeddedtest succeeds when statically compiled w/ your upcoming updates in tor-static?

@mibmo
Copy link
Contributor Author

mibmo commented Jun 17, 2022

Yep! :)

I haven't tested all of Bine's functionality, but when building tor-static it worked just fine using "normally" (I tested HS & proxy)

@cretz
Copy link
Owner

cretz commented Jun 17, 2022

Fantastic! Feel free to squash and merge whenever. Once the tor-static is merged and we know it's all working, we may want to change process/embedded/process.go to default to this version in a subsequent PR.

@mibmo
Copy link
Contributor Author

mibmo commented Jul 1, 2022

Fantastic! Feel free to squash and merge whenever. Once the tor-static is merged and we know it's all working, we may want to change process/embedded/process.go to default to this version in a subsequent PR.

I don't have the permissions to do that, could you? but otherwise, sounds great! :)

@cretz cretz merged commit a157733 into cretz:master Jul 1, 2022
@cretz
Copy link
Owner

cretz commented Jul 1, 2022

Done, thanks!

@cretz cretz mentioned this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants