New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the algorithm in validate_terminates #1220

Open

arnaudgolfouse wants to merge 3 commits into creusot-rs:master from arnaudgolfouse:fix-validate-terminates

Collaborator

arnaudgolfouse commented Nov 5, 2024

@jhjourdan this is what we talked about.

The new algorithm is stricter:

trait Foo {
    fn foo1();
    fn foo2();
}

impl Foo for i32 {
    fn foo1() {}
    fn foo2() { g() }
}

fn f<T: Foo>() { <T as Foo>::foo1() }
fn g() { f::<i32>(); }

is now rejected, saying that f might call i32::foo2 because of the T: Foo bound.

arnaudgolfouse added 3 commits

November 5, 2024 13:52


          Rework the termination check

c87f104


          Better error messages

a684112


          Update tests

10d2a13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet