-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the constants.py file adding the list of foundation models available in Amazon Bedrock #2170
Conversation
This PR updates the list of foundation models available in Amazon Bedrock to reflect the latest offerings.
Disclaimer: This review was made by a crew of AI Agents. Code Review Comment for PR #2170OverviewThis pull request updates the Positive Aspects
Issues and Recommendations1. Version ConsistencyThere are discrepancies in date formats present in the model names. Standardizing the date format across all entries will improve uniformity and reduce confusion: # Current:
"bedrock/anthropic.claude-3-5-sonnet-20241022-v2:0",
"bedrock/anthropic.claude-3-5-sonnet-20240620-v1:0",
# Recommended:
"bedrock/anthropic.claude-3-5-sonnet-20240620-v1:0",
"bedrock/anthropic.claude-3-5-sonnet-20241022-v2:0", 2. Model Family GroupingTo enhance clarity, consider grouping models by their provider family. This organization will make future updates simpler while improving readability: "bedrock": [
# Amazon models
"bedrock/amazon.nova-pro-v1:0",
"bedrock/amazon.nova-micro-v1:0",
"bedrock/amazon.nova-lite-v1:0",
# Anthropic models
"bedrock/anthropic.claude-3-5-sonnet-20241022-v2:0",
"bedrock/anthropic.claude-3-5-sonnet-20240620-v1:0",
"bedrock/anthropic.claude-3-5-haiku-20241022-v1:0",
# ... rest of Anthropic models
] 3. DocumentationAdding a comment header is highly recommended to document the file's purpose and update process. This practice improves maintainability, especially for future developers: """
Available foundation models in Amazon Bedrock.
This list is maintained to reflect the latest model offerings from Bedrock.
Last updated: 2024-02-19
""" Additional Suggestions
from dataclasses import dataclass
from typing import List
@dataclass
class BedrockModel:
id: str
version: str
provider: str
BEDROCK_MODELS: List[BedrockModel] = [
BedrockModel(id="amazon.nova-pro", version="v1:0", provider="amazon"),
# ... additional models
] ConclusionThe changes made in this pull request are well-structured and are integral to keeping the Risk Assessment
Links to Historical Context
|
@cardofe we should also add the instance profiles. We currently can't use models that live a different region than the code is running in. All we would need to do is add the instance profile names to the list of models, which is just the model ID with a I created an alternate PR to include them as well as your additions. #2225 |
Add the cross-region inference profiles to increase throughput and improve resiliency by routing your requests across multiple AWS Regions during peak utilization bursts.
@rupe120, thanks for your feedback! I updated the constant.py file with the inference profiles. |
Fix the model order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @cardofe!!
…ilable in Amazon Bedrock (#2170) * Update constants.py This PR updates the list of foundation models available in Amazon Bedrock to reflect the latest offerings. * Update constants.py with inference profiles Add the cross-region inference profiles to increase throughput and improve resiliency by routing your requests across multiple AWS Regions during peak utilization bursts. * Update constants.py Fix the model order --------- Co-authored-by: Brandon Hancock (bhancock_ai) <109994880+bhancockio@users.noreply.github.com>
This PR updates the list of foundation models available in Amazon Bedrock to reflect the latest offerings. This is my small contribution to this awesome project!