Skip to content

fix: prevent task output loss when mixing sync and async tasks #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rakshit-gen wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix: prevent task output loss when mixing sync and async tasks #4139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/crewai/src/crewai/crew.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,9 +957,9 @@ async def _aexecute_tasks(
pending_tasks.append((task, async_task, task_index))
else:
if pending_tasks:
task_outputs = await self._aprocess_async_tasks(
task_outputs.extend(await self._aprocess_async_tasks(
pending_tasks, was_replayed
)
))
pending_tasks.clear()

context = self._get_context(task, task_outputs)
Expand All @@ -973,7 +973,7 @@ async def _aexecute_tasks(
self._store_execution_log(task, task_output, task_index, was_replayed)

if pending_tasks:
task_outputs = await self._aprocess_async_tasks(pending_tasks, was_replayed)
task_outputs.extend(await self._aprocess_async_tasks(pending_tasks, was_replayed))

return self._create_crew_output(task_outputs)

Expand All @@ -987,7 +987,7 @@ async def _ahandle_conditional_task(
) -> TaskOutput | None:
"""Handle conditional task evaluation using native async."""
if pending_tasks:
task_outputs = await self._aprocess_async_tasks(pending_tasks, was_replayed)
task_outputs.extend(await self._aprocess_async_tasks(pending_tasks, was_replayed))
pending_tasks.clear()

return check_conditional_skip(
Expand Down Expand Up @@ -1152,7 +1152,7 @@ def _execute_tasks(
futures.append((task, future, task_index))
else:
if futures:
task_outputs = self._process_async_tasks(futures, was_replayed)
task_outputs.extend(self._process_async_tasks(futures, was_replayed))
futures.clear()

context = self._get_context(task, task_outputs)
Expand All @@ -1166,7 +1166,7 @@ def _execute_tasks(
self._store_execution_log(task, task_output, task_index, was_replayed)

if futures:
task_outputs = self._process_async_tasks(futures, was_replayed)
task_outputs.extend(self._process_async_tasks(futures, was_replayed))

return self._create_crew_output(task_outputs)

Expand All @@ -1179,7 +1179,7 @@ def _handle_conditional_task(
was_replayed: bool,
) -> TaskOutput | None:
if futures:
task_outputs = self._process_async_tasks(futures, was_replayed)
task_outputs.extend(self._process_async_tasks(futures, was_replayed))
futures.clear()

return check_conditional_skip(
Expand Down