Add an AssertionHandler to the middleware #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update package name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using this repo in addition to itzg/saml-auth-proxy but I wanted to add some extra functionality where on login take the assertion from the SAML provider and add RBAC to Grafana.
To do this I added a
AssertionHandlerto samlsp middleware. Inside of theServeACSfunction before creating the session I call theAssertionHandler.HandleAssertionfunction and give it the assertion.This way you can create your own AssertionHandler and have it do whatever you want, in my case add RBAC to opensource Grafana.
Let me know if there is something I should change. I am currently using a fork for my purpose but would love to see this added upstream.