Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeadm.md #3538

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Update kubeadm.md #3538

merged 1 commit into from
Apr 8, 2020

Conversation

cortopy
Copy link
Contributor

@cortopy cortopy commented Apr 7, 2020

Kubeadm no longer deletes files in /etc/cni/net.d

What type of PR is this?

/kind documentation

What this PR does / why we need it:

I can see there was a long discussion about how kubeadm used to delete files in /etc/cni/net.d. Even the docs this commit modifies are mentioned there.

However, kubeadm merged this PR to solve the issue and it no longer deletes files in /etc/cni/net.d

In fact, when reseting a kubeadm cluster, there is this piece of information in the terminal:

The reset process does not clean CNI configuration. To do so, you must remove /etc/cni/net.d

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@cortopy cortopy requested review from mrunalp and runcom as code owners April 7, 2020 18:20
@openshift-ci-robot openshift-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 7, 2020
@openshift-ci-robot openshift-ci-robot requested review from rhatdan and sameo and removed request for rhatdan April 7, 2020 18:20
@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2020
@openshift-ci-robot
Copy link

Hi @cortopy. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

Hi @cortopy. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Juan Jimenez-Anca <cortopy@users.noreply.github.com>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 7, 2020
@cortopy
Copy link
Contributor Author

cortopy commented Apr 7, 2020

/assign @umohnani8

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #3538 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3538   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files         100      100           
  Lines        7723     7723           
=======================================
  Hits         3396     3396           
  Misses       4030     4030           
  Partials      297      297           

@saschagrunert
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2020
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @cortopy 🙏

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cortopy, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cortopy, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@saschagrunert
Copy link
Member

/retest

@haircommander
Copy link
Member

haircommander commented Apr 8, 2020

However, kubeadm merged this PR to solve the issue and it no longer deletes files in /etc/cni/net.d

that's awesome to hear, the clearing of the directory always confused me and was a source of headaches for new users

thank you very much for the patch @cortopy

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

Apr 08 13:21:43 ip-172-18-15-16.ec2.internal crio[15608]: time="2020-04-08 13:21:43.169589297Z" level=warning msg="Failed to open /etc/passwd: open /var/lib/containers/storage/overlay/87939d719a64e1ea148acacc182b941beaa6098389cd1617017c21aaf57352af/merged/etc/passwd: no such file or directory"
Apr 08 13:21:43 ip-172-18-15-16.ec2.internal crio[15608]: time="2020-04-08 13:21:43.169931486Z" level=warning msg="Failed to open /etc/group: open /var/lib/containers/storage/overlay/87939d719a64e1ea148acacc182b941beaa6098389cd1617017c21aaf57352af/merged/etc/group: no such file or directory"

this is the only error I see that could be related to the failure here

unrelated to this PR though,
/retest

@openshift-ci-robot
Copy link

@cortopy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_features_fedora eda8c6e link /test e2e_features_fedora

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

happened again...

@haircommander haircommander merged commit af2509f into cri-o:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants