-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubeadm.md #3538
Update kubeadm.md #3538
Conversation
Hi @cortopy. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
Hi @cortopy. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Juan Jimenez-Anca <cortopy@users.noreply.github.com>
/assign @umohnani8 |
Codecov Report
@@ Coverage Diff @@
## master #3538 +/- ##
=======================================
Coverage 43.97% 43.97%
=======================================
Files 100 100
Lines 7723 7723
=======================================
Hits 3396 3396
Misses 4030 4030
Partials 297 297 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @cortopy 🙏
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cortopy, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cortopy, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
this is the only error I see that could be related to the failure here unrelated to this PR though, |
@cortopy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
happened again... |
Kubeadm no longer deletes files in /etc/cni/net.d
What type of PR is this?
/kind documentation
What this PR does / why we need it:
I can see there was a long discussion about how kubeadm used to delete files in
/etc/cni/net.d
. Even the docs this commit modifies are mentioned there.However, kubeadm merged this PR to solve the issue and it no longer deletes files in
/etc/cni/net.d
In fact, when reseting a kubeadm cluster, there is this piece of information in the terminal:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?