-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRIO changes to support split filesystem #7269
Conversation
Hi @kannon92. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
004a4bd
to
724cd91
Compare
4fcea23
to
74bfc6e
Compare
02f5dce
to
9f11b11
Compare
9f11b11
to
48a9e18
Compare
48a9e18
to
8d88d57
Compare
A friendly reminder that this PR had no activity for 30 days. |
/retest |
1 similar comment
/retest |
@sohankunkerkar I think there is a legit failure here. I'll see if I find the cause. |
c57220f
to
d8bf1ee
Compare
/retest |
@haircommander we think that this one needs #7606 as we are hitting caching issues where |
d8bf1ee
to
702ac88
Compare
/retest |
1 similar comment
/retest |
hmm... the latest build still uses the older version of [skunkerk@ci-op-ygyzh78h-39a11-buildhost ~]$ crictl --version
crictl version 1.28.0
|
Signed-off-by: Kevin Hannon <kannon1992@gmail.com>
66858d1
to
c30ce40
Compare
/lgtm |
/retest |
1 similar comment
/retest |
@saschagrunert could you override this? The other e2e jobs pass. we moved the integration tests to another PR so this should be mergable now. |
/override ci/prow/ci-cgroupv2-e2e |
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-cgroupv2-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Implement Image_Fs_Info as part of the separate gc KEP. We should not merge unless this KEP is approved. TODO: Add a link.
Opening this up now to gather feedback on feasibility of this implementation.
Note, since I had a few changes in other areas, I vendored these changes here. I already opened up a PR into c/storage. Kubernetes is based on KEP approval.
Which issue(s) this PR fixes:
Special notes for your reviewer:
We are having some problems with the integration tests picking up an older version of crictl. I moved the integration tests to #7269 just to move this PR through.
Does this PR introduce a user-facing change?