[WIP] [release-1.26] Cherry-pick changes from containers/image project

[kwilczynski]

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from containers/image project.

These changes carry fixes that need to be backported to CRI-O.

Related:

• Fix excessive memory and disk usage when sharing layers containers/image#2636

Note

This cherry-pick brings the following Pull Requests as a dependency:

• storage.storageImageDestination.Commit(): leverage image options containers/image#2067
• Fix and simplify storage tests containers/image#2147

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski
Once this PR has been reviewed and has the lgtm label, please assign fidencio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kwilczynski]

/retest

[kwilczynski]

/cc @cri-o/cri-o-maintainers
/cc @mtrmac

[kwilczynski]

/retest

[openshift-ci]

@kwilczynski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	6914fa6	link	true	/test images
ci/prow/e2e-agnostic	6914fa6	link	true	/test e2e-agnostic
ci/prow/e2e-gcp	6914fa6	link	true	/test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mtrmac]

Per containers/image#2636 (comment) , the original bug was introduced in c/image 5.30.0, so the backport should not be necessary.

But, also, I didn’t actually test that the code in older versions does not have the bug.

[kwilczynski]

Per containers/image#2636 (comment) , the original bug was introduced in c/image 5.30.0, so the backport should not be necessary.

But, also, I didn’t actually test that the code in older versions does not have the bug.

See: #8881 (comment)

[kwilczynski]

Closing. No longer needed.

[kwilczynski]

/close

[openshift-ci]

@kwilczynski: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.