Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log events only related to a valid CNI configuration file. #232

Conversation

roman-kiselenko
Copy link
Member

Logs only .conf, .json and .conflist files.

Context #208 (comment)

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Reduce noisy log messages

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Some additional context is here.

Does this PR introduce a user-facing change?

Log events only related to a valid CNI configuration file.

@kwilczynski @saschagrunert PTAL

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 9, 2024
@coveralls
Copy link

coveralls commented Nov 9, 2024

Pull Request Test Coverage Report for Build 11867963021

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 62.125%

Totals Coverage Status
Change from base Build 11626223460: 0.7%
Covered Lines: 538
Relevant Lines: 866

💛 - Coveralls

@roman-kiselenko roman-kiselenko force-pushed the feature/log-only-cni-config-files branch 2 times, most recently from 0cfe056 to b661a2b Compare November 10, 2024 06:43
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a suggestion, otherwise LGTM

pkg/ocicni/ocicni.go Outdated Show resolved Hide resolved
Logs only .conf, .json and .conflist files.

Signed-off-by: roman-kiselenko <roman.kiselenko.dev@gmail.com>
@roman-kiselenko roman-kiselenko force-pushed the feature/log-only-cni-config-files branch from b661a2b to e129e48 Compare November 16, 2024 06:32
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roman-kiselenko, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fd63d0c into cri-o:master Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants