Scoped bash does not appear to receive the correct configuration

[seanvaleo]

Steps To Reproduce

Reported by a user:

When I scope top, I get three interfaces (log, events, metrics) that are all connected
When I scope bash, I get two interfaces (log, cribl) and only log is connected
Why the difference?

We would expect that the same configuration would yield the same results.

Possible Cause:
The handling of SCOPE_CONF_PATH in the AppScope code differs slightly from other SCOPE_ environment variables.
getenv works well for handling SCOPE_CONF_PATH as an environment variable for the top command. Unfortunately, getenv does not behave the same way for bash

Repro Steps (thanks @michalbiesek):

LD_PRELOAD=./lib/linux/x86_64/libscope.so SCOPE_CONF_PATH=<path_to_scope.yml> top
LD_PRELOAD=./lib/linux/x86_64/libscope.so SCOPE_CONF_PATH=<path_to_scope.yml> bash

Environment

- AppScope: 1.3.3
- OS: ubuntu
- Architecture: x86
- Kernel: ?

Requested priority

None

Relevant log output

No response

[michalbiesek]

The potential fix is presented in #1503:
getenv function is not able to find the SCOPE_CONF_PATH if I use the following logic:

• retrieve address of getenv see initFn and call it with SCOPE_CONF_PATH I am able to successfully retrieve the configuraiton file
• I think we encounter simillar issue in the past, see : Provide bash procs with the correct config file  #447
• See that bash implements own getenv:
  https://github.com/bminor/bash/blob/master/lib/sh/getenv.c
• Unit test & integration test were added to confirm fix

To test it manually You can do following:

First terminal:

scope run bash

Second terminal:

scope inspect <bash_pid>