Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cloud: Add control for binary redaction of console to scope.yml #970

Closed
jrcheli opened this issue May 26, 2022 · 3 comments · Fixed by #982
Closed

For Cloud: Add control for binary redaction of console to scope.yml #970

jrcheli opened this issue May 26, 2022 · 3 comments · Fixed by #982
Assignees
Milestone

Comments

@jrcheli
Copy link
Contributor

jrcheli commented May 26, 2022

We currently have control of this feature with SCOPE_ALLOW_BINARY_CONSOLE.

Our motivation for adding it to our config file is that we think it might be useful on a process by process basis (custom config).

Another action that we've talked about taking at the same time, is that we think we should change the default value of this binary console redaction feature disabled by default...

@jrcheli jrcheli self-assigned this May 26, 2022
@jrcheli jrcheli added this to the Next Minor (1.1.0) milestone May 26, 2022
jrcheli added a commit that referenced this issue Jun 2, 2022
Fix the console integration test to account for this.
@jrcheli
Copy link
Contributor Author

jrcheli commented Jun 2, 2022

In the series of commits on the feature/970-binary-console-config branch...

  • added a spot for allow_binary_console in cfg
  • changed the env var processing to set this state in cfg and ctl
  • fixed integration test to account that default allow_binary_console was false, and now is true.
  • add yml processing from scope.yml to set the state in cfg
  • output this state in json when reporting config
  • I copied the state for allow_binary_console from cfg to ctl, which we've said we don't want to do. Come back to this.

@michalbiesek
Copy link
Contributor

cc: @jrcheli
I allowed myself to continue your great work here:

  • added a spot for allow_binary_console in cfg
  • changed the env var processing to set this state in cfg and ctl
  • fixed integration test to account that default allow_binary_console was false, and now is true.
  • add yml processing from scope.yml to set the state in cfg
  • output this state in json when reporting config
  • I copied the state for allow_binary_console from cfg to ctl, which we've said we don't want to do. Come back to this.

I decided not to make changes related to the last point. It would require a refactor ctl module, which IMHO can be done later.

@jrcheli
Copy link
Contributor Author

jrcheli commented Jun 7, 2022

Looks great! I tweaked processEvtWatchBinary(), to use cfgAllowBinaryConsoleSetFromStr() just for consistency with other similar functions. This isn't a functional difference. Confirmed that things are working end-to-end by inspecting the output of this quick test.

rm /tmp/scope.log
LD_PRELOAD=lib/linux/x86_64/libscope.so SCOPE_ALLOW_BINARY_CONSOLE=false SCOPE_LOG_LEVEL=info ps -ef
cat /tmp/scope.log

michalbiesek pushed a commit to michalbiesek/appscope that referenced this issue Feb 19, 2023
michalbiesek pushed a commit to michalbiesek/appscope that referenced this issue Feb 19, 2023
michalbiesek pushed a commit to michalbiesek/appscope that referenced this issue Feb 19, 2023
Fix the console integration test to account for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants