-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Cloud: Add control for binary redaction of console to scope.yml #970
Comments
Fix the console integration test to account for this.
In the series of commits on the feature/970-binary-console-config branch...
|
cc: @jrcheli
I decided not to make changes related to the last point. It would require a refactor |
Looks great! I tweaked processEvtWatchBinary(), to use cfgAllowBinaryConsoleSetFromStr() just for consistency with other similar functions. This isn't a functional difference. Confirmed that things are working end-to-end by inspecting the output of this quick test.
|
Fix the console integration test to account for this.
We currently have control of this feature with SCOPE_ALLOW_BINARY_CONSOLE.
Our motivation for adding it to our config file is that we think it might be useful on a process by process basis (custom config).
Another action that we've talked about taking at the same time, is that we think we should change the default value of this binary console redaction feature disabled by default...
The text was updated successfully, but these errors were encountered: