Docs/commits from Jakub #1021
Merged
Docs/commits from Jakub #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbiesek
reviewed
Jul 4, 2022
There was a problem hiding this comment.
@abetones
Looks great to me.
Example view
Before changes from this Pull Request:
After the changes from this Pull Request:
|
Looks great to me! Merging! Thanks @jakub-cribl and @abetones! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two tiny unrelated fixes.
One adds an OpenGraph meta image tag so that if somebody posts a link to our docs on Twitter or LinkedIn, the correct image will appear in the tweet/post.
The other improves readability the schema reference by breaking long lists into columns.
Thanks to @jakub-cribl for these fixes!