Docs / update changelog for 1.1.1 #1030

abetones · 2022-07-08T06:49:10Z

No description provided.

abetones · 2022-07-08T06:58:32Z

@jrcheli @michalbiesek @iapaddler @seanvaleo

Just to be sure ...

Besides being on the CDN, are the AWS Lambda Layers available in Docker containers too?
Is my write-up on sshd scoping #1006 complete? In the issue itself there's a lot about environment variables and also mention of being unable to connect from another shell via ssh to the sshd server. I'm pretty sure, @jrcheli , that you were saying these don't need to be part of the Changelog description.

I tried to answer these below here #1030 (comment) -- John

jrcheli · 2022-07-08T16:11:56Z

website/src/pages/docs/changelog.md

+
+### New Features and Improvements
+
+- [#1017](https://github.com/criblio/appscope/issues/1017) AppScope downloadable assets now include [AWS Lambda Layers](https://docs.aws.amazon.com/lambda/latest/dg/gettingstarted-concepts.html#gettingstarted-concepts-layer) for x86 and for ARM, along with their respective MD5 checksums.


1017 is the wrong issue number for the New Features and Improvements entry... I think it should be #964 instead.

BTW, putting a the link to the lambda docs here is brilliant... bravo!

Oops, copypasta error, fixing, thanks!

jrcheli · 2022-07-08T16:13:55Z

website/src/pages/docs/changelog.md

+  - `MD5 checksum`: [https://cdn.cribl.io/dl/scope/1.1.1/linux/x86_64/aws-lambda-layer-x86_64.zip.md5](https://cdn.cribl.io/dl/scope/1.1.1/linux/x86_64/aws-lambda-layer-x86_64.zip.md5)
+- `AWS Lambda Layer for ARM`: [https://cdn.cribl.io/dl/scope/1.1.1/linux/aarch64/aws-lambda-layer-aarch64.zip](https://cdn.cribl.io/dl/scope/1.1.1/linux/aarch64/aws-lambda-layer-aarch64.zip)
+  - `MD5 checksum`: [https://cdn.cribl.io/dl/scope/1.1.1/linux/aarch64/aws-lambda-layer-aarch64.zip.md5](https://cdn.cribl.io/dl/scope/1.1.1/linux/aarch64/aws-lambda-layer-aarch64.zip.md5)
+


Re: MD5 checksums... I think we shouldn't call out the MD5 checksums here, since we didn't call them out for the for the /scope assets above. 🤷‍♂️

The lambda links aren't quite right... These are the correct links:
https://cdn.cribl.io/dl/scope/1.1.1/linux/x86_64/aws-lambda-layer.zip
https://cdn.cribl.io/dl/scope/1.1.1/linux/aarch64/aws-lambda-layer.zip

If it helps, I was able to test them by replacing "1.1.1" with "1.1.1-tc1" just for the sake of the test.

Fixed, thanks John!

jrcheli · 2022-07-08T16:43:51Z

website/src/pages/docs/changelog.md

+
+### Fixes
+
+- [#1017](https://github.com/criblio/appscope/issues/1017) AppScope now correctly handles the single-byte message that web clients sometimes send before their ClientHello message. This enables AppScope to correctly produce HTTP events when you scope a server with TLS enabled.


This is totally on me, but we might want to change this text in the known issue and change log. What we ultimately learned was that the web client wasn't actually sending an extra single-byte message to the server. This was the way I described the known issue, but in fixing it, we learned that the server was "peeking" at the first byte of data, before processing it normally, so it looked to us like an extra received byte from the perspective of our library that is running inside the server process.

See if you can make something from this mess. =)
AppScope now correctly handles the "peek" flag in interposed functions that receive network data. Before this change, received data could be double counted which could confound AppScope's protocol detection. Specifically, this fix enables AppScope to correctly produce HTTP events when scoping a server that uses "peek" flags.

jrcheli · 2022-07-08T16:55:02Z

website/src/pages/docs/changelog.md

+### Fixes
+
+- [#1017](https://github.com/criblio/appscope/issues/1017) AppScope now correctly handles the single-byte message that web clients sometimes send before their ClientHello message. This enables AppScope to correctly produce HTTP events when you scope a server with TLS enabled.
+- [#1006](https://github.com/criblio/appscope/issues/1006) AppScope now correctly instruments the child processes of an sshd process started by a server. Prior to this, AppScope already instrumented the parent sshd process by interposing the `execve` system call. Now, in order to instrument the child sshd processes too, AppScope also interposes the `execv` system call, and overrides some of the sandboxing that sshd normally imposes using `setrlimit`. Changing `setrlimit` settings enables AppScope to perform actions required by AppScope's configured backend and transport, such as establishing connections, creating threads, and creating files.


I'm wondering if it's possible to shorten things starting with the second sentence?
Don't feel bound to this, but I would say "Prior to this, AppScope was missing child sshd processes because it was not interposing the execv system call. It was also necessary to override some of the sandboxing imposed by setrlimit so AppScope could function properly."

jrcheli · 2022-07-08T17:09:53Z

Here's how I would answer your questions above, @abetones ...
Besides being on the CDN, are the AWS Lambda Layers available in Docker containers too?
We aren't putting AWS Lambda Layers in the docker containers. Lambda doesn't support containers, and containers don't support Lambda...

Is my write-up on https://github.com/criblio/appscope/issues/1006 complete?
I think what you have is complete, and agree that the discussion on environment variables was really us investigating and trying to understand what we were seeing... and therefore doesn't belong in the change log. I did suggest that we shorten the description of 1006 in a comment above, but this is just a suggestion.

abetones · 2022-07-08T17:28:09Z

Here's how I would answer your questions above, @abetones ... Besides being on the CDN, are the AWS Lambda Layers available in Docker containers too? We aren't putting AWS Lambda Layers in the docker containers. Lambda doesn't support containers, and containers don't support Lambda...

Thanks, John, I've clarified the assets section to reflect this.

jrcheli · 2022-07-08T19:15:06Z

Looks great to me! Merging!

Abe Raher added 2 commits July 7, 2022 23:48

update changelog for 1.1.1

f1e09d1

simplify

89c1f6d

abetones requested review from michalbiesek, iapaddler, jrcheli and seanvaleo July 8, 2022 06:58

abetones linked an issue Jul 8, 2022 that may be closed by this pull request

1.1.1 Changelog #1028

Closed

jrcheli reviewed Jul 8, 2022

View reviewed changes

fix errors per review

48755c7

clarify asset availability

5d4b5b3

jrcheli mentioned this pull request Jul 8, 2022

Docs/1029 docs updates 1.1.1 #1031

Merged

Abe Raher added 2 commits July 8, 2022 11:32

fine-tune language

eb4f436

fine-tune asset links

db29692

jrcheli merged commit c342b1f into master Jul 8, 2022

jrcheli deleted the docs/1028-changelog-1.1.1 branch July 8, 2022 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs / update changelog for 1.1.1 #1030

Docs / update changelog for 1.1.1 #1030

abetones commented Jul 8, 2022

abetones commented Jul 8, 2022 •

edited by jrcheli

Loading

jrcheli Jul 8, 2022 •

edited

Loading

abetones Jul 8, 2022

jrcheli Jul 8, 2022 •

edited

Loading

abetones Jul 8, 2022

jrcheli Jul 8, 2022 •

edited

Loading

jrcheli Jul 8, 2022

jrcheli commented Jul 8, 2022

abetones commented Jul 8, 2022

jrcheli commented Jul 8, 2022


		### New Features and Improvements

		- [#1017](https://github.com/criblio/appscope/issues/1017) AppScope downloadable assets now include [AWS Lambda Layers](https://docs.aws.amazon.com/lambda/latest/dg/gettingstarted-concepts.html#gettingstarted-concepts-layer) for x86 and for ARM, along with their respective MD5 checksums.


		### Fixes

		- [#1017](https://github.com/criblio/appscope/issues/1017) AppScope now correctly handles the single-byte message that web clients sometimes send before their ClientHello message. This enables AppScope to correctly produce HTTP events when you scope a server with TLS enabled.

Docs / update changelog for 1.1.1 #1030

Docs / update changelog for 1.1.1 #1030

Conversation

abetones commented Jul 8, 2022

abetones commented Jul 8, 2022 • edited by jrcheli Loading

jrcheli Jul 8, 2022 • edited Loading

Choose a reason for hiding this comment

abetones Jul 8, 2022

Choose a reason for hiding this comment

jrcheli Jul 8, 2022 • edited Loading

Choose a reason for hiding this comment

abetones Jul 8, 2022

Choose a reason for hiding this comment

jrcheli Jul 8, 2022 • edited Loading

Choose a reason for hiding this comment

jrcheli Jul 8, 2022

Choose a reason for hiding this comment

jrcheli commented Jul 8, 2022

abetones commented Jul 8, 2022

jrcheli commented Jul 8, 2022

abetones commented Jul 8, 2022 •

edited by jrcheli

Loading

jrcheli Jul 8, 2022 •

edited

Loading

jrcheli Jul 8, 2022 •

edited

Loading

jrcheli Jul 8, 2022 •

edited

Loading