Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1067) Fix attach process by name error: index out of range #1068

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

michalbiesek
Copy link
Contributor

  • provide exit status message without panic

Closes #1067

Test instructions:

docker run --privileged --rm -it cribl/scope:dev-x86_64
top &
top &
scope attach top
Found multiple processes matching that name...
ID	PID	USER	SCOPED	COMMAND
1 	16 	root	false 	top
2 	17 	root	false 	top
Select an ID from the list:

When choosing 3, you should see:

Invalid Selection

Instead of panic described in #1067

- provide exit status message without panic

Closes #1067
@michalbiesek michalbiesek requested a review from seanvaleo August 9, 2022 09:32
@jrcheli
Copy link
Contributor

jrcheli commented Aug 11, 2022

Looks great! Merging!

@jrcheli jrcheli merged commit 0595084 into master Aug 11, 2022
@jrcheli jrcheli deleted the fix/1067-attach-index-out-of-range branch August 11, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Attach process by name index out of range
3 participants