Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/updates 1.2.1 #1220

Merged
merged 8 commits into from
Nov 28, 2022
Merged

Docs/updates 1.2.1 #1220

merged 8 commits into from
Nov 28, 2022

Conversation

abetones
Copy link
Contributor

No description provided.

@abetones abetones linked an issue Nov 28, 2022 that may be closed by this pull request
1.2.0 or 1.2.1 wording fixes related to config editor #1176
Closed
@michalbiesek
Copy link
Contributor

@abetones
I think You do not want to include the following file: website/src/pages/docs/schema-reference.md.

The creation of schema-reference.md is automated by the website Github Action workflow,
ref: #997 (comment)

@michalbiesek
Copy link
Contributor

michalbiesek commented Nov 28, 2022 •
edited
Loading

Regarding filesystem as one word:
I think You want to do the following change here:

appscope/docker/docs/layout.js

Line 78 in 50f90d9

fs: 'File System',

@abetones
Copy link
Contributor Author

Thank you @michalbiesek for explaining the right way to make the desired change ... that's done now.

@abetones abetones merged commit 0d80136 into master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iapaddler iapaddler Awaiting requested review from iapaddler

@seanvaleo seanvaleo Awaiting requested review from seanvaleo

@michalbiesek michalbiesek Awaiting requested review from michalbiesek

@jrcheli jrcheli Awaiting requested review from jrcheli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.2.0 or 1.2.1 wording fixes related to config editor
2 participants
@abetones @michalbiesek