[#1279 2/4] Extend contrib code with coredumper #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- commit e292a1288ed86f623af6a7f17cc529dcc52f782e - ref: https://github.com/madscientist/google-coredumper
- add mechanism to cache `coredumper` library build
- extend Makefiles to support building `coredumper`
…dumper` - Handle by `-fpic` flag Ref: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options
- 2.69 is the version supported in Ubuntu 18.04
This was referenced Jan 30, 2023
|
Looks great to me. Confirmed that the version we imported matches e292a1288ed86f623af6a7f17cc529dcc52f782e from git@github.com:madscientist/google-coredumper.git. Reviewed subsequent changes to integrate with the build as well. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduced the
coredumperlibrary - library useful for generate core dump from AppScope code.coredumperlibrary is done in 4ba434e, rest of changes in this PR are described in each commit message.Important note
This Pull Request does not integrate and linking the
coredumperin AppScope code it contains only changes required to add and build thecoredumperlibrary