Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing alpine based integration tests - dependency issue with python #967

Merged
merged 3 commits into from
May 25, 2022

Conversation

michalbiesek
Copy link
Contributor

  • Alpine latest points to 3.16.0 [1]
  • default Python version is 3.10 there [2]

Link: docker-library/official-images@6675d08 [1]
Link: docker-library/python@1a63123 [2]

The other commit is just a cosmetic change to store used version of LTP in single variable via Docker ARG

@michalbiesek michalbiesek force-pushed the feat-fix-syscall-test branch from 90bd83b to 150ce86 Compare May 25, 2022 11:09
@michalbiesek michalbiesek changed the title Fix failing alpine syscall test - dependency issue with python Fix failing alpine based integration tests - dependency issue with python May 25, 2022
Copy link
Collaborator

@seanvaleo seanvaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with hard coding a version for the integration test. Michal pointed out to me that we need to lock the version to 3.15 as a later version would pull in python 3.10 which requires substantial changes to the test (certificate stringency), not related to the functionality.

@jrcheli
Copy link
Contributor

jrcheli commented May 25, 2022

Thank you @michalbiesek and @seanvaleo!

@jrcheli jrcheli merged commit 84d98f8 into master May 25, 2022
@jrcheli jrcheli deleted the feat-fix-syscall-test branch May 25, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants