Merge pull request #57 from amcgoogan/patch-libuv-fs-event-leak

Patch for libuv watcher leak
criblio · Oct 19, 2024 · fc6fafe · fc6fafe
2 parents 720e3db + 6d99f75
commit fc6fafe
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/NodeBuilder.js b/src/NodeBuilder.js
@@ -198,6 +198,9 @@ class NodeJsBuilder {
     await patchFile(
       this.nodePath('src', 'node.cc'),
       join(this.patchDir, 'node.cc.patch'));
+    await patchFile(
+      this.nodePath('deps', 'uv', 'src', 'win', 'fs-event.c'),
+      join(this.patchDir, 'fs-event.c.patch'));
   }
 
   async patchNodeCompileIssues() {

diff --git a/src/patch/18.20.4/fs-event.c.patch b/src/patch/18.20.4/fs-event.c.patch
@@ -0,0 +1,11 @@
+--- a/deps/uv/src/win/fs-event.c
++++ b/deps/uv/src/win/fs-event.c
+@@ -266,6 +266,8 @@ short_path_done:
+     }
+
+     dir_to_watch = dir;
++    uv__free(short_path);
++    short_path = NULL;
+     uv__free(pathw);
+     pathw = NULL;
+   }