upgraded nodejs version to 20.18.0 #58
Conversation
avcribl
force-pushed
the
feat-bump-20-18-0
branch
from
ac9d4dc to
ee1e52f
Compare
| @@ -255,7 +256,7 @@ class NodeJsBuilder { | |||
| // 4. process mainAppFile (gzip, base64 encode it) - could be a placeholder file | |||
| // 5. kick off ./configure & build | |||
| buildFromSource(uploadBuild, cache, container, arch, ptrCompression) { | |||
| const makeArgs = isWindows ? ['x64', 'noetw', 'no-cctest'] : [`-j${os.cpus().length}`]; | |||
| const makeArgs = isWindows ? ['x64', 'no-cctest'] : [`-j${os.cpus().length}`]; | |||
There was a problem hiding this comment.
Support for etw (Event Tracing for Windows) has been removed since nodejs v19.0.0 onward. nodejs/node#43652
It's mentioned in the nodejs v19 changelog as well.
avcribl
force-pushed
the
feat-bump-20-18-0
branch
2 times, most recently
from
9645bde to
bb13d37
Compare
avcribl
force-pushed
the
feat-bump-20-18-0
branch
from
bb13d37 to
fa6eb14
Compare
|
@avcribl which of the patch files are new and which ones are copy/paste from prior node versions? |
| o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0 | ||
| - o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0 | ||
| + | ||
| + # o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0 |
There was a problem hiding this comment.
why do we need to disable this option?
There was a problem hiding this comment.
There has been a commit that was introduced in nodejs 20.17.0 that enforces enablingv8_enable_sandbox flag whenever v8_enable_pointer_compression flag is enabled. This causes failure of building nodejs for Windows OS when we enable the pointer compression flag. Apparently, such a thing does not work well in the Windows OS. I also did not find any build with the pointer compression flag enabled to run and test for Windows OS on the nodejs CI pipeline. The build failure message can be seen in CRIBL-28701 ticket.
azure-pipelines.ymldevtoolsetversion 10js2bin-builderimageLinux x64 and Windows artifacts have been successfully built in the CI pipeline.