Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for devcontainer #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for devcontainer #59

wants to merge 1 commit into from

Conversation

michalbiesek
Copy link
Contributor

@michalbiesek michalbiesek commented Dec 23, 2024 •
edited
Loading

By adding DevContainer support, we can utilize a Linux-based build environment, which allows us to operate independently of Xcode and avoids the use of Darwin/macOS-specific flags. This would better reflect the build performed in CI

With current build on Mac:

node js2bin.js --ci --container=true --pointer-compress=false --node=20.18.0 --size=6MB --size=4MB --arch=linux/arm64 --platform=linux
2024-12-23T12:58:36.557Z - running: make -j12 ...
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=0

nromito
nromito reviewed Dec 23, 2024
View reviewed changes
src/NodeBuilder.js Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you revert the formatting changes given you're not touching this file outside of those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've removed the commit related to formatting changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nromito nromito nromito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalbiesek @nromito