Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix field with boolean option, e.g. [deprecation = true] #43

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fix field with boolean option, e.g. [deprecation = true] #43

merged 4 commits into from
Dec 11, 2024

Conversation

millin
Copy link
Contributor

@millin millin commented Dec 2, 2024

No description provided.

@millin millin force-pushed the fix_boolean_option branch from bd37d3c to 7ccd6fd Compare December 3, 2024 18:51
@criccomini
Copy link
Owner

Looks like there's some style related issues. PTAL.

@criccomini criccomini merged commit 8d3ddc3 into criccomini:main Dec 11, 2024
1 check passed
@criccomini
Copy link
Owner

Published to:

https://pypi.org/project/proto-schema-parser/1.4.3/

@millin
Copy link
Contributor Author

millin commented Dec 12, 2024

@criccomini Hi!
Why did you remove the changes to generator? Now it writes the option as [deprecation = “true”].

@criccomini
Copy link
Owner

I was under the impression that you made that change to placate the Python type hinting linter.I've updated the code in this PR re-add it: #44.

A test would have prevented this confusion. I have added one.

I have published 1.4.4 with #44 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@millin @criccomini