Fix SteveSanderson#124 - Use hasOwnProperty to check for bucket exist…

…ence If a mapped observable has a value that is a property of `Object.prototype`, `findBucket` returns that property's value instead of a `simpleObjectLookup` instance.
crissdev · Feb 13, 2015 · 1cf041d · 1cf041d
1 parent db6424f
commit 1cf041d
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/dist/knockout.mapping.js b/dist/knockout.mapping.js
@@ -831,7 +831,7 @@
             }
 
             var bucket = buckets[bucketKey];
-            if (bucket === undefined) {
+            if (!buckets.hasOwnProperty(bucketKey)) {
                 bucket = new SimpleObjectLookup();
                 buckets[bucketKey] = bucket;
             }

diff --git a/dist/knockout.mapping.min.js b/dist/knockout.mapping.min.js
diff --git a/dist/knockout.mapping.min.js.map b/dist/knockout.mapping.min.js.map
diff --git a/knockout.mapping.js b/knockout.mapping.js
@@ -826,7 +826,7 @@
             }
 
             var bucket = buckets[bucketKey];
-            if (bucket === undefined) {
+            if (!buckets.hasOwnProperty(bucketKey)) {
                 bucket = new SimpleObjectLookup();
                 buckets[bucketKey] = bucket;
             }

diff --git a/spec/issues.js b/spec/issues.js
@@ -332,4 +332,11 @@ QUnit.test('Issue #203', function(assert) {
 
     assert.deepEqual(ko.mapping.toJS(viewModel), {connectionId: 1, type: 'thirdType', thirdTypeProperty: 'thirdTypeProperty'});
 });
+
+//https://github.com/SteveSanderson/knockout.mapping/issues/124
+QUnit.test('Issue #124', function(assert) {
+    var model = ko.mapping.fromJS({ foo: 'constructor' });
+    assert.equal(model.foo(), 'constructor');
+});
+
 })();