Support node 13 #141
Closed
Support node 13 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @nsivertsen thank you so much for opening this and sorry for taking so long to reply. LGTM. And I'll merge it in, asap. Once again thank you! |
|
Closing this and reopen when I can get to it. Thank you for your time! Much appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! First of all, thanks for this wonderful library. I'm really enjoying using it.
I've been trying to use it with Node 13's new ESM support, and saw that that was still missing, hence this PR. I've basically copied exactly what Preact is doing: preactjs/preact#2451.
Of the sub-packages, only
goober-autoprefixeris currently being built, as it appears the other ones don't need to be built at all, as far as I can see?I've added a basic test, taken directly from HTM: developit/htm#164
The filesize test is currently failing, which is why this might fail in CI.