Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_wait option #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShimmerGlass
Copy link

In some cases we prefer to restart the chef run to pull potential new
changes instead of waiting indefinitely for the choregraphie to unlock.

Copy link
Contributor

@kamaradclimber kamaradclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test for this scenario and update documentation?

libraries/primitive_consul_lock.rb Outdated Show resolved Hide resolved
libraries/primitive_consul_lock.rb Outdated Show resolved Hide resolved
In some cases we prefer to restart the chef run to pull potential new
changes instead of waiting indefinitely for the choregraphie to unlock.
@ShimmerGlass
Copy link
Author

Im not sure how to go about adding a test for this use case, do you have an idea ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants