implement multi-oidc client support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clems4ever
changed the title
|
It would be better to merge the previous one before reviewing this one as it's stacked on top of it. |
clems4ever
force-pushed
the
multi-oidc-client
branch
from
fb844ca to
5822bb6
Compare
clems4ever
force-pushed
the
multi-oidc-client
branch
from
d6bcdf3 to
5fea9d3
Compare
clems4ever
changed the title
|
Would you mind splitting the test fixing in another review? This would make it easier to see the functional changes here. |
this allows to specify which authenticator is in use. It could be either LDAP, OIDC or both.
clems4ever
force-pushed
the
multi-oidc-client
branch
from
6e8f9e9 to
60b34cc
Compare
manu-ns
approved these changes
Nov 26, 2021
pierrecdn
reviewed
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each domain is protected by a dedicated application defined at the authorization server level.
This would be easier to rotate one application secret in case of compromise for instance.