Distinct enabled state monitoring #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, both the state and the up/down intent were merged. It was preventing us from declaring a BGP session in maintenance while shutting the BGP only on one side. With this commit, state and enabled are completely separate. We do not reuse "status" from NetBox DCIM: - to avoid conflict if we want to redefined the state at the device level - "state" is more appropriate to define if a device is in production/validation etc... Status is really accurate. "enabled" is the same as in OpenConfig and minimize possible misinterpretation of what it does.
Monitoring state defined the criticity of monitoring alerts for the asset. Possible usage: - critical: on-call alerts - warning: working-hours alerts only - disabled: no alerts (lab, tests, etc...) The recommended implementation would be to only consider the monitoring state if a device is in production, because: - there is no reason to raise an alert for a device not in production - if we have to change the monitoring status during a maintenance/issue, it would be difficult to know what is the expected status once back to production
fdomain
approved these changes
Aug 9, 2023
kpetremann
added a commit
to kpetremann/data-aggregation-api
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #7