Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token authorization to Agent.force_leave #79

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

zanloy
Copy link
Contributor

@zanloy zanloy commented Jul 2, 2024

By default the requests to the Agent.force_leave method does not pass any authorization token. On a cluster that requires authorization, this means that you can not remove dead nodes from the client library. This PR should resolve that by passing the token param the same as the other methods do.

@mbrulatout
Copy link
Contributor

great thanks !
Nice to see people actually using this :)

@mbrulatout mbrulatout merged commit 98be675 into criteo:master Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants