-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chinese translation to 7.0 by windmilladventure001 #37
Conversation
Update Chinese translation to 7.0 by windmilladventure001
Can you omit the weidu update, please? It needs to be done and tested separately. Thanks. |
…o-24900 Revert "Update WeiDU to 24900"
done. In fact, when an updated version of weidu.exe exists in the game directory, the file will automatically upgrade itself before installation. So, if there were issues with updating weidu, someone might have already reported the issue. LOL |
Thanks. Yeah, I know about the auto-update thing. Even if everything is fine, I prefer not to mix together different things within one commit. I'll update the weidu separately when I publish a small update, hopefully, this or next week. I'll merge the support for Chinese language into it as well. |
Thank you. Some people have discussed this: So updating Weidu.exe is also part of the translation process. |
Understood. I was not aware of this issue. In any case, updating weidu might have some unintended other effect as the result of changes made to the executable. I will need to review what's been done to weidu and make sure there is nothing potentially problematic for us. |
#36 (comment)