Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese translation to 7.0 by windmilladventure001 #37

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Update Chinese translation to 7.0 by windmilladventure001 #37

merged 7 commits into from
Sep 17, 2024

Conversation

MephistoSatanDevil
Copy link
Contributor

@critto-bg
Copy link
Owner

Can you omit the weidu update, please? It needs to be done and tested separately. Thanks.

@MephistoSatanDevil
Copy link
Contributor Author

MephistoSatanDevil commented Sep 16, 2024

Can you omit the weidu update, please? It needs to be done and tested separately. Thanks.

done.

In fact, when an updated version of weidu.exe exists in the game directory, the file will automatically upgrade itself before installation. So, if there were issues with updating weidu, someone might have already reported the issue. LOL

@critto-bg
Copy link
Owner

Thanks. Yeah, I know about the auto-update thing. Even if everything is fine, I prefer not to mix together different things within one commit. I'll update the weidu separately when I publish a small update, hopefully, this or next week. I'll merge the support for Chinese language into it as well.

@MephistoSatanDevil
Copy link
Contributor Author

MephistoSatanDevil commented Sep 16, 2024

Thanks. Yeah, I know about the auto-update thing. Even if everything is fine, I prefer not to mix together different things within one commit. I'll update the weidu separately when I publish a small update, hopefully, this or next week. I'll merge the support for Chinese language into it as well.

Thank you.
In fact, we update Weidu.exe because the UTF-8 encoded Chinese console prompts would become garbled under the old version of weidu.exe. The latest version of weidu.exe has resolved this issue, so Chinese modders often update weidu.exe to version 24900 when localizing mods at present.

Some people have discussed this:
The-Gate-Project/DarkHorizons#23
This is another related discussion:
BGforgeNet/bg2-wildmage#30

So updating Weidu.exe is also part of the translation process.

@critto-bg
Copy link
Owner

Understood. I was not aware of this issue. In any case, updating weidu might have some unintended other effect as the result of changes made to the executable. I will need to review what's been done to weidu and make sure there is nothing potentially problematic for us.

@critto-bg critto-bg merged commit 071b1c0 into critto-bg:master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants