net: Argument cannot be negative (NEGATIVE_RETURNS)

CID 302719 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) img_raw_fd(img) is passed to a parameter that cannot be negative. Signed-off-by: Adrian Reber <areber@redhat.com>
criupatchwork · Oct 20, 2020 · 59010ad · 59010ad
1 parent 82cd3bb
commit 59010ad
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/criu/net.c b/criu/net.c
@@ -1915,7 +1915,12 @@ static inline int dump_nftables(struct cr_imgset *fds)
 		return -1;
 
 	img = img_from_set(fds, CR_FD_NFTABLES);
-	img_fd = dup(img_raw_fd(img));
+	img_fd = img_raw_fd(img);
+	if (img_fd < 0) {
+		pr_err("Getting raw FD failed\n");
+		goto nft_ctx_free_out;
+	}
+	img_fd = dup(img_fd);
 	if (img_fd < 0) {
 		pr_perror("dup() failed");
 		goto nft_ctx_free_out;