Use icu_list to emit list in diagnostics.
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Oct 21, 2022
| @@ -539,3 +541,47 @@ impl From<Vec<Span>> for MultiSpan { | |||
| MultiSpan::from_spans(spans) | |||
| } | |||
| } | |||
|
|
|||
| #[macro_export] | |||
| macro_rules! pluralize { | |||
There was a problem hiding this comment.
issue: we should be using icu_pluralrules for this
There was a problem hiding this comment.
fluent also supports this built-in
| } else { | ||
| let data_provider = rustc_baked_icu_data::baked_data_provider(); | ||
| let locale = icu_locid::locale!("en").into(); | ||
| let list_formatter = icu_list::ListFormatter::try_new_and_with_length_unstable( |
There was a problem hiding this comment.
thought: ideally the list formatter is built once and stored in the session or something
There was a problem hiding this comment.
basically it needs to be stored alongside the fluent stuff
| assert!(value_count > 0); | ||
|
|
||
| if value_count > spread_limit { | ||
| format!("multiple {descr}{s}", s = pluralize!(value_count),) |
There was a problem hiding this comment.
the descr stuff shouldn't be handled here. if we want to handle it, it ought to be handled via Fluent's builtin support for pluralization
|
Thanks for the review! I'll dig into the usage part of the diagnostic infrastructure, before addressing these review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.