Skip to content

Conversation

@K4sku
Copy link
Contributor

@K4sku K4sku commented Jul 3, 2025

What this does

This PR filters out models from Parsera that have nil values for :provider or :id.
This prevents crashes on refreshing models which makes the cited statement from the site valid:

This method is safe to call from Rails applications, background jobs, or any running Ruby process.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Related issues

Fixes #270

@infinityrobot infinityrobot mentioned this pull request Jul 7, 2025
17 tasks
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (0f60067) to head (0c9507c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   89.71%   89.72%           
=======================================
  Files          75       75           
  Lines        2811     2812    +1     
  Branches      555      555           
=======================================
+ Hits         2522     2523    +1     
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crmne crmne merged commit 78482e5 into crmne:main Jul 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] RubyLLM.models.refresh! raises ArgumentError: comparison of Array with Array failed (ArgumentError)

2 participants