MORUS: do not needlessly allocate heap memory #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All arrays are, by default, allocated on the heap. Therefore, for every call of the
morus_initialization
method, a new set of constant arrays was allocated making the repeated initialisation not feasible, especially on cards with unreliable garbage collection.Make these constant arrays class members instead so that they are allocated only once.
Detected-by: JCProfilerNext
Line chart depicting the repeated garbage collection on the NXP JCOP3 J3H145 card: