Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov #292

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add codecov #292

merged 2 commits into from
Dec 8, 2022

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Dec 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@846144e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage        ?   73.25%           
=======================================
  Files           ?       45           
  Lines           ?     5580           
  Branches        ?        0           
=======================================
  Hits            ?     4087           
  Misses          ?     1493           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J08nY J08nY merged commit 19338dc into main Dec 8, 2022
@J08nY J08nY deleted the feat/codecov branch December 8, 2022 13:43
@adamjanovsky
Copy link
Collaborator

@J08nY Can this be incorporated also into local development? I.e. can we create a pre-commit task for this? It's uncomfortable to discover failing pipelines only when they get to remote.

@J08nY
Copy link
Member Author

J08nY commented Dec 18, 2022

Well you can track code coverage when running tests. I do not think it makes sense to include anything based on that to a pre-commit. Otherwise every commit would run the test suite, I think that should not happen and be separate. If you want to look at the coverage diff you can check codecov manually, or just push and see the pipeline results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants