Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce-reference-bool #317

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Introduce-reference-bool #317

merged 3 commits into from
Feb 16, 2023

Conversation

adamjanovsky
Copy link
Collaborator

Minor fixes and introduces __bool__() method on Reference object so that one can select reference-rich certificates with [x for x in dset if x.heuristics.policy_processed_references]

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 74.35% // Head: 74.34% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d55ab3e) compared to base (c2d0bf8).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   74.35%   74.34%   -0.01%     
==========================================
  Files          45       45              
  Lines        5606     5606              
==========================================
- Hits         4168     4167       -1     
- Misses       1438     1439       +1     
Impacted Files Coverage Δ
src/sec_certs/dataset/dataset.py 64.36% <ø> (-0.21%) ⬇️
src/sec_certs/sample/certificate.py 85.25% <50.00%> (-1.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamjanovsky adamjanovsky merged commit c0084cf into main Feb 16, 2023
@adamjanovsky adamjanovsky deleted the introduce-reference-bool branch February 16, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant