Adjust to upcoming base Julia change #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the `@system` macro to be compatible with JuliaLang/julia#56497, which re-orders the point at which a type is published into the bindings table until after it is complete. This package was (uniquely among all julia packages) relying on the binding existing during field definition (via a call to `typefor`). Unfortunately, there isn't really a great place to define as the system (currently) does not gurantee an order of the evaluation of field types with respect to other global statements inside the struct evaluation. The only place that satiesfies the criteria that a) incomplete struct is avilable b) it is evaluated before any field types is the supertype declaration, so this PR shoves the definition of `typefor` there. This works both before and after the change, although it is quite messy. In the future, there may be a way to forward declare an incomplete type, but for the time being, this is the best I could come up with.
|
Took a while to merge. Thanks for reporting and taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the
@systemmacro to be compatible with JuliaLang/julia#56497, which re-orders the point at which a type is published into the bindings table until after it is complete. This package was (uniquely among all julia packages) relying on the binding existing during field definition (via a call totypefor).Unfortunately, there isn't really a great place to define as the system (currently) does not gurantee an order of the evaluation of field types with respect to other global statements inside the struct evaluation. The only place that satiesfies the criteria that
a) incomplete struct is avilable
b) it is evaluated before any field types
is the supertype declaration, so this PR shoves the definition of
typeforthere.This works both before and after the change, although it is quite messy. In the future, there may be a way to forward declare an incomplete type, but for the time being, this is the best I could come up with.