Implement Direct3DDevice8::GetInfo #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSnowfall
force-pushed
the
getinfo
branch
from
3726fe6 to
db8caa8
Compare
|
Verified to be working properly at least on D3DDEVINFOID_VCACHE queries. I'm unsure if MinGW needs any additional header definitions, but MSVC is fine as is. |
elishacloud
reviewed
Sep 21, 2024
WinterSnowfall
force-pushed
the
getinfo
branch
from
db8caa8 to
cd8a803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Direct3DDevice8::GetInfo, which partially maps onto Direct3DDevice9::CreateQuery followed by queries on a IDirect3DQuery9 object.
The specific details of the implementation, especially the response codes have been recreated based on the information available in the MS DX8.1 SDK. Unfortunately, the documentation you can find online on the topic is not at all extensive.
This is largely relevant on Nvidia for D3DDEVINFOID_VCACHE type queries, since some games expect some data there and native drivers do indeed return non-zero information (see here for some samples). Beside games, VCACHE queries have also been observed to be initiated by D3D9 D3DX libraries, though I am unsure if this is also the case in D3D8.
Needs a bit of testing and validation, submitting as draft for now.