Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hardware accelerated virtualization on Linux runners #47

Closed
jacob-carlborg opened this issue Feb 23, 2023 · 4 comments
Closed

Support hardware accelerated virtualization on Linux runners #47

jacob-carlborg opened this issue Feb 23, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jacob-carlborg
Copy link
Contributor

The GitHub hosted larger Linux runners recently got support for hardware accelerated nested virtualization. See https://github.blog/changelog/2023-02-23-hardware-accelerated-android-virtualization-on-actions-windows-and-linux-larger-hosted-runners. CPA should be able to detect when support for hardware accelerated nested virtualization is available and enable it where possible.
@jacob-carlborg jacob-carlborg added the enhancement New feature or request label Feb 23, 2023
@jmayclin jmayclin mentioned this issue Nov 9, 2023
Closed
jacob-carlborg added a commit that referenced this issue Feb 17, 2024
@jacob-carlborg
Fix #47: Enable hardware acceleration for Linux hosts (KVM)
ab5d1b1 
GitHub Linux runners have been upgraded [1] and now hardware accelerated
nested virtualization is available.

This also removes most logic around accelerators, since QEMU can pick
the best one out of several specified.

[1] https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/
jacob-carlborg added a commit that referenced this issue Feb 18, 2024
@jacob-carlborg
Fix #47: Enable hardware acceleration for Linux hosts (KVM)
4f2e32a 
GitHub Linux runners have been upgraded [1] and now hardware accelerated
nested virtualization is available.

This also removes most logic around accelerators, since QEMU can pick
the best one out of several specified.

[1] https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/
manxorist added a commit to OpenMPT/openmpt that referenced this issue Feb 19, 2024
@manxorist
[Mod] build: CI: GitHub: Change CPA runners to run on Linux instead o…
58a2348 
…f macOS thanks to <cross-platform-actions/action#47>.

git-svn-id: https://source.openmpt.org/svn/openmpt/trunk/OpenMPT@20146 56274372-70c3-4bfc-bfc3-4c3a0b034d27
@manxorist
Copy link

I am seeing speedups of ~2x and even up to 8x in some cases from switching VM host from macOS to Ubuntu. This is great.

manxorist added a commit to OpenMPT/openmpt that referenced this issue Feb 19, 2024
@manxorist
Merged revision(s) 20146 from trunk/OpenMPT:
881a3a4 
[Mod] build: CI: GitHub: Change CPA runners to run on Linux instead of macOS thanks to <cross-platform-actions/action#47>.
........


git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.31@20149 56274372-70c3-4bfc-bfc3-4c3a0b034d27
manxorist added a commit to OpenMPT/openmpt that referenced this issue Feb 19, 2024
@manxorist
Merged revision(s) 20146 from trunk/OpenMPT:
2370b24 
[Mod] build: CI: GitHub: Change CPA runners to run on Linux instead of macOS thanks to <cross-platform-actions/action#47>.
........


git-svn-id: https://source.openmpt.org/svn/openmpt/branches/OpenMPT-1.30@20150 56274372-70c3-4bfc-bfc3-4c3a0b034d27
@manxorist manxorist mentioned this issue Feb 19, 2024
Open
@jacob-carlborg
Copy link
Contributor Author

I am seeing speedups of ~2x and even up to 8x in some cases from switching VM host from macOS to Ubuntu. This is great.

Awesome. It's not officially announced by GitHub, but so far it's always available 🤞.

@Xottab-DUTY Xottab-DUTY mentioned this issue Feb 19, 2024
Merged
@Xottab-DUTY
Copy link

Xottab-DUTY commented Feb 19, 2024 •
edited
Loading

Thaanks man!!
After switching to Linux runners instead of macOS, we now have pure identical build times with FreeBSD compared to Ubuntu, and just a bit slower with OpenBSD. And the runs are stable now, no random failures.

@jacob-carlborg-apoex
Copy link

Thaanks man!!
After switching to Linux runners instead of macOS, we now have pure identical build times with FreeBSD compared to Ubuntu, and just a bit slower with OpenBSD. And the runs are stable now, no random failures.

That great to hear, thanks.

@manxorist manxorist mentioned this issue Feb 19, 2024
Open
korli added a commit to korli/action that referenced this issue Mar 15, 2024
@korli
Merge tag 'v0.23.0' into merge
a72f43b 
Release 0.23.0

Added:
- Add support for FreeBSD 14.0 ([cross-platform-actions#74](cross-platform-actions#74))
- Add post run step that prints the VM output
- Support hardware accelerated virtualization on Linux runners ([cross-platform-actions#47](cross-platform-actions#47))

Fixed:
- OpenBSD VM fails during "Initializing VM" with QEMU on macOS ([cross-platform-actions#73](cross-platform-actions#73))
- Use same options for rsync in both directions ([cross-platform-actions#76](cross-platform-actions#76))

Changed:
- Update qemu to 8.2.0 for CVTPS2PD fix ([cross-platform-actions#78](cross-platform-actions#78))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jacob-carlborg @Xottab-DUTY @manxorist @jacob-carlborg-apoex