Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armv7-unknown-linux-musleabihf/armv7-linux-musleabihf hard-coded NEON support #252

Closed
briansmith opened this issue Jan 25, 2019 · 1 comment · Fixed by #255
Closed

armv7-unknown-linux-musleabihf/armv7-linux-musleabihf hard-coded NEON support #252

briansmith opened this issue Jan 25, 2019 · 1 comment · Fixed by #255

Comments

@briansmith
Copy link
Contributor

briansmith commented Jan 25, 2019 •
edited
Loading

See https://github.com/rust-embedded/cross/blob/718a19cd68fb09428532d1317515fe7303692b47/docker/armv7-unknown-linux-musleabihf/Dockerfile#L30

According to rust-lang/rust#47765 this is wrong.

See also rust-lang/rust#56947 where new NEON-always-available target triples were added.
@jamesmunns
Copy link
Contributor

jamesmunns commented Jan 25, 2019 •
edited
Loading

Hey @briansmith, would you mind please removing this in a PR? I can kick off CI once you submit it.

@briansmith briansmith mentioned this issue Jan 26, 2019
Merged
bors bot added a commit that referenced this issue Aug 25, 2019
@bors @briansmith
Merge #255
9ef7231 
255: Stop hard-coding NEON support for armv7-unknown-linux-musleabihf. r=reitermarkus a=briansmith

Fixes #252.

Signed-off-by: Brian Smith <brian@briansmith.org>

Co-authored-by: Brian Smith <brian@briansmith.org>
@bors bors bot closed this as completed in 1232d0e Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop hard-coding NEON support for armv7-unknown-linux-musleabihf.
2 participants
@briansmith @jamesmunns