Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DOCKER_OPTS to CROSS_CONTAINER_OPTS #770

Closed
1 of 2 tasks
Alexhuszagh opened this issue Jun 9, 2022 · 0 comments · Fixed by #772
Closed
1 of 2 tasks

Rename DOCKER_OPTS to CROSS_CONTAINER_OPTS #770

Alexhuszagh opened this issue Jun 9, 2022 · 0 comments · Fixed by #772
Labels
feature-request

Comments

@Alexhuszagh
Copy link
Contributor

Checklist

Describe your request

Currently, we don't use Docker in all instances (I almost entirely use podman), but to provide custom options have to define DOCKER_OPTS. Slightly more general, and namespaced, would be CROSS_CONTAINER_OPTS. For backwards compatibility, we could support both for a while, preferring the latter, then the former, and then a few releases later warn the user if they're still using DOCKER_OPTS.

Describe why this would be a good inclusion for cross

No response
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 9, 2022
@Alexhuszagh
Add CROSS_CONTAINER_OPTS environment variable.
9a498e3 
Rename `DOCKER_OPTS` to `CROSS_CONTAINER_OPTS`, and currently prefer
`CROSS_CONTAINER_OPTS` to `DOCKER_OPTS`, although both are still valid.

Closes cross-rs#770.
This was referenced Jun 9, 2022
Merged
Merged
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 9, 2022
@Alexhuszagh
Add CROSS_CONTAINER_OPTS environment variable.
40931a7 
Rename `DOCKER_OPTS` to `CROSS_CONTAINER_OPTS`, and currently prefer
`CROSS_CONTAINER_OPTS` to `DOCKER_OPTS`, although both are still valid.

Closes cross-rs#770.
Alexhuszagh added a commit to Alexhuszagh/cross that referenced this issue Jun 9, 2022
@Alexhuszagh
Add CROSS_CONTAINER_OPTS environment variable.
4da3a9a 
Rename `DOCKER_OPTS` to `CROSS_CONTAINER_OPTS`, and currently prefer
`CROSS_CONTAINER_OPTS` to `DOCKER_OPTS`, although both are still valid.

Closes cross-rs#770.
bors bot added a commit that referenced this issue Jun 12, 2022
@bors @Alexhuszagh
Merge #772
239e8cb 
772: Add `CROSS_CONTAINER_OPTS` environment variable. r=Emilgardis a=Alexhuszagh

Rename `DOCKER_OPTS` to `CROSS_CONTAINER_OPTS`, and currently prefer `CROSS_CONTAINER_OPTS` to `DOCKER_OPTS`, although both are still valid.

Closes #770.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@bors bors bot closed this as completed in 5d6855b Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CROSS_CONTAINER_OPTS environment variable. Alexhuszagh/cross
1 participant
@Alexhuszagh