Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross Doesn't Write a CACHEDIR.TAG #835

Closed
Alexhuszagh opened this issue Jun 22, 2022 · 0 comments · Fixed by #836
Closed

Cross Doesn't Write a CACHEDIR.TAG #835

Alexhuszagh opened this issue Jun 22, 2022 · 0 comments · Fixed by #836
Assignees
@Alexhuszagh
Labels
bug

Comments

@Alexhuszagh
Copy link
Contributor

cargo does not write CACHEDIR.TAG in the target directory if it already exists, and since we create one if the directory does not exist for permission issues, we need to write a CACHEDIR.TAG file if it does not exist. This particularly affects #785, since it means we copy over the entire target directory over.

The specification can be found here.
@Alexhuszagh Alexhuszagh mentioned this issue Jun 22, 2022
Merged
bors bot added a commit that referenced this issue Jun 22, 2022
@bors @Alexhuszagh
Merge #836
cc61dc8 
836: Add a cache dir tag when creating a target directory. r=Emilgardis a=Alexhuszagh

Ensure `cross` is similar in functionality to `cargo`, and this minimizes network traffic by applications that may copy the project but do not wish to copy compiled code.

Closes #835.

Co-authored-by: Alex Huszagh <ahuszagh@gmail.com>
@bors bors bot closed this as completed in f046ff5 Jun 22, 2022
@vaffeine vaffeine mentioned this issue Aug 30, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alexhuszagh Alexhuszagh

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a cache dir tag when creating a target directory. Alexhuszagh/cross
1 participant
@Alexhuszagh