Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop parsing arguments to cross run after --. #1049

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Stop parsing arguments to cross run after --. #1049

merged 2 commits into from
Oct 3, 2022

Conversation

zachs18
Copy link
Contributor

@zachs18 zachs18 commented Oct 3, 2022 •
edited
Loading

Resolves #1048.

Stop parsing arguments to cross run after --, but still add them to args.all so they will be passed to the program being run.

@zachs18 zachs18 requested a review from a team as a code owner October 3, 2022 06:49
@zachs18 zachs18 changed the title Stop parsing arguments after --. Stop parsing arguments to cross run after --. Oct 3, 2022
Emilgardis
Emilgardis approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors bors bot merged commit bad04b4 into cross-rs:main Oct 3, 2022
@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Build succeeded:

@Alexhuszagh Alexhuszagh mentioned this pull request Nov 19, 2022
Closed
11 tasks
@Emilgardis Emilgardis added this to the v0.3.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

cross run interprets the program's arguments as its own (ignores --).
3 participants
@zachs18 @Emilgardis @Alexhuszagh