Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump musl to 1.2.3, like done in rust 1.71 #1346

Merged
merged 1 commit into from
Dec 23, 2023
Merged

bump musl to 1.2.3, like done in rust 1.71 #1346

merged 1 commit into from
Dec 23, 2023

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis requested a review from a team as a code owner October 15, 2023 11:20
@Emilgardis
Copy link
Member Author

bors try --target musl

bors bot added a commit that referenced this pull request Oct 15, 2023
@bors
Try #1346: --target *musl*
f5975c5
@bors
Copy link
Contributor

bors bot commented Oct 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target musl

bors bot added a commit that referenced this pull request Oct 15, 2023
@bors
Try #1346: --target *musl*
1a0fcca
@bors
Copy link
Contributor

bors bot commented Oct 15, 2023

try

Build failed:

@Emilgardis
Copy link
Member Author

bors try --target musl

bors bot added a commit that referenced this pull request Oct 15, 2023
@bors
Try #1346: --target *musl*
ab66cfa
@Emilgardis
Copy link
Member Author

fixed the verbose flag issue in #1347

@bors
Copy link
Contributor

bors bot commented Oct 15, 2023

try

Build failed:

@Emilgardis Emilgardis added this to the v0.3.0 milestone Oct 26, 2023
@Emilgardis Emilgardis mentioned this pull request Oct 27, 2023
Open
@Emilgardis Emilgardis mentioned this pull request Dec 23, 2023
Merged
@Emilgardis Emilgardis closed this Dec 23, 2023
@Emilgardis Emilgardis reopened this Dec 23, 2023
@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Dec 23, 2023
@Emilgardis Emilgardis added this pull request to the merge queue Dec 23, 2023
Merged via the queue into main with commit 2979814 Dec 23, 2023
22 checks passed
@Emilgardis Emilgardis deleted the bump-musl branch December 23, 2023 21:13
@Mossaka
Copy link

Mossaka commented Jan 19, 2024

I am wondering why "GCC_CONFIG += --enable-default-pie" was removed? It causes the musl libc not compile with PIE.

@Mossaka Mossaka mentioned this pull request Jan 19, 2024
Merged
@Emilgardis
Copy link
Member Author

Hmm you're right, i dont know why i removed it

@Emilgardis Emilgardis mentioned this pull request Jan 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 19, 2024
@Emilgardis
Add GCC_CONFIG option to enable default PIE (#1418)
185398b 
This was removed in #1346 for unknown reasons. I'm adding it back in.
@YOU54F YOU54F mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Emilgardis @Mossaka