allow build.rs to write files to the volume

[gnzlbg]

Closes #145 .

[gnzlbg]

@homunkulus try

[jamesmunns]

Hey @gnzlbg, I know this had been discussed before, however at the time it was decided that it was better practice to do all building in the target/ directory, using the OUT_DIR environment variable exposed to build.rs scripts. You can see an example of this in one of my repos.

Since this does impose some problems for people that are porting existing makefiles, it might make sense to allow disabling this constraint, but I would prefer this be an explicit opt-in.

Would you consider adding a cli flag to toggle this change with a "loud" name, like --allow-container-to-modify-files (okay, thats maybe too long, but you get the idea hopefully), so that the current behavior is not changed by default?

Also for reference, only collaborators can trigger CI at the moment.

Also also, thanks for all the attention on this project lately!

[gnzlbg]

I think it would be better to try to detect this and suggest that everything must happen in the OUT_DIR, but I don’t know a good place to try to catch this.

…

On Wed 2. May 2018 at 21:39, James Munns ***@***.***> wrote: Hey @gnzlbg <https://github.com/gnzlbg>, I know this had been discussed before, however at the time it was decided that it was better practice to do all building in the target/ directory, using the OUT_DIR environment variable exposed to build.rs scripts. You can see an example of this in one of my repos <https://github.com/jamesmunns/nrf52dk-sys/blob/master/build.rs#L13>. Since this does impose some problems for people that are porting existing makefiles, it might make sense to allow disabling this check, but I would prefer this be an explicit opt-in. Would you consider adding a cli flag to toggle this change with a "loud" name, like --allow-container-to-modify-files (okay, thats maybe too long, but you get the idea hopefully), so that the current behavior is not changed by default? Also for reference, only collaborators can trigger CI at the moment. Also also, thanks for all the attention on this project lately! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#201 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3Npo43qEX3_lO8Yw8pIkqBevjBUXHvks5tugtwgaJpZM4Tvv7I> .

[gnzlbg]

This is written in the readme, and I have no idea how to detect this easily, so I am closing it. I agree that it is better to never modify the project directory.