-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade musl to 1.1.24 #485
Conversation
At this point, I think it's best to NOT downgrade MUSL on the cross images. A few months have passed with MUSL 1.2.0 merged in and:
@malbarbo Which packages have you seen breaking "in the wild" due to this? |
The problem can happen with any project that interacts with C. See https://github.com/ericonr/rust-time64. |
Is this still relevant? I'm guessing it is since the |
It is, I just tested it with a Dockerfile with OpenSSL. Sample code to reproduce is (based off of sheldon-cross). Dockerfile FROM ghcr.io/cross-rs/armv7-unknown-linux-musleabihf:main
COPY install_openssl.sh /
RUN apt-get update && apt-get install wget
RUN wget https://github.com/rossmacarthur/sheldon-cross/blob/trunk/docker/install_openssl.sh
RUN bash /install_openssl.sh linux-armv4 arm-linux-musleabihf-
ENV OPENSSL_DIR=/openssl \
OPENSSL_STATIC=1 \
OPENSSL_INCLUDE_DIR=/openssl/include \
OPENSSL_LIB_DIR=/openssl/lib Then, set the appropriate target in git clone https://github.com/rossmacarthur/sheldon
cd sheldon
cargo build --target armv7-unknown-linux-musleabihf Which produces a lot of errors related to 64-bit time (undefined references to I'm using the latest stable Rust version (1.61.0) and cross installed from git (the most recent commit as of the time this comment was posted). |
bors try --target -musl |
tryBuild succeeded: |
bors r+ |
Build succeeded: |
Fixes #478.