Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebsd: Add libprocstat.so #582

Merged
merged 1 commit into from
Sep 5, 2021
Merged

freebsd: Add libprocstat.so #582

merged 1 commit into from
Sep 5, 2021

Conversation

svenstaro
Copy link
Contributor

If we don't add this library, we'll eventually run into linking problems due to libprocstat.so not being found.

@svenstaro svenstaro requested review from Dylan-DPC-zz and a team as code owners August 28, 2021 05:05
@svenstaro
Copy link
Contributor Author

I have no idea why this fails to build.

@Emilgardis
Copy link
Member

Its unrelated, probably nix-rust/nix#1491

Need to bump nix version

@Emilgardis
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Aug 28, 2021
@bors
Try #582:
0e985aa
@bors
Copy link
Contributor

bors bot commented Aug 28, 2021

try

Build succeeded:

@svenstaro
Copy link
Contributor Author

So bors says it works but the CI still fails?

@Emilgardis
Copy link
Member

Emilgardis commented Aug 29, 2021 •
edited
Loading

We merged a fix for the CI in #583, but github actions doesn't run on the (would be) merge commit, it runs on the prs ref.
If you want to fix it, you could rebase your branch, but there is no need, as bors runs on the merged ref.

I don't really feel comfortable merging this as I'm not familiar with FreeBSD. But it doesn't seem like it'd be bad to have.

EDIT: A changelog entry is missing also. Could you add one?

@svenstaro svenstaro closed this Aug 29, 2021
@svenstaro svenstaro reopened this Aug 29, 2021
@svenstaro
freebsd: Add libprocstat.so
979f044 
If we don't add this library, we'll eventually run into linking problems due to libprocstat.so not being found.
@Emilgardis
Copy link
Member

@reitermarkus r=me if you think this is ok, i suspect it is

@svenstaro
Copy link
Contributor Author

Rebased and added CHANGELOG entry.

I don't really feel comfortable merging this as I'm not familiar with FreeBSD. But it doesn't seem like it'd be bad to have.

Since this really just adds a library I think the possible bad impact is fairly limited. Without this, my fairly boring Rust program didn't compile and with it, it does. :)

Emilgardis
Emilgardis approved these changes Aug 29, 2021
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svenstaro
Copy link
Contributor Author

Thank you for taking care of cross. I think cross fills an important role in the Rust ecosystem and it needs love. :)

@svenstaro
Copy link
Contributor Author

Any chance for a good ol' mergerino?

@Emilgardis
Copy link
Member

ill merge it, don't see that should be an issue.

Thank you!

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2021
@bors @svenstaro
Merge #582
ccb2687 
582: freebsd: Add libprocstat.so r=Emilgardis a=svenstaro

If we don't add this library, we'll eventually run into linking problems due to libprocstat.so not being found.

Co-authored-by: Sven-Hendrik Haase <svenstaro@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 4, 2021

Build failed:

  • rust-embedded.cross

@svenstaro
Copy link
Contributor Author

Huh how did this fail?

@Emilgardis
Copy link
Member

https://dev.azure.com/rust-embedded/cross/_build/results?buildId=930&view=logs&j=6e847cca-24ce-5b2d-e476-7fadc4226834&t=4f4f83a6-27d6-5138-5def-6e63a5c30d1a&l=16603

404, could be temporary or it needs to be changed

@svenstaro
Copy link
Contributor Author

It needs to be updated to https://pkg.freebsd.org/FreeBSD:12:i386/quarterly/All/openssl-1.1.1l,1.txz. I'm submitting another PR I guess.

@svenstaro
Copy link
Contributor Author

Alright @Emilgardis I posted a fix as #588.

@Emilgardis
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 5, 2021

Build succeeded:

@bors bors bot merged commit 770b7f1 into cross-rs:master Sep 5, 2021
svenstaro added a commit to svenstaro/miniserve that referenced this pull request Sep 5, 2021
@svenstaro
Go back to official cross FreeBSD releases
e3d6b56 
This is fine now that cross-rs/cross#582 is merged.
@svenstaro svenstaro deleted the patch-1 branch September 6, 2021 01:48
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

@Dylan-DPC-zz Dylan-DPC-zz Awaiting requested review from Dylan-DPC-zz

Assignees
No one assigned
Labels
A-bsd Area: BSD-family targets container-images enhancement
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@svenstaro @Emilgardis @Alexhuszagh