Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI tests to use local cross build. #881

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Update CI tests to use local cross build. #881

merged 1 commit into from
Jun 29, 2022

Conversation

Alexhuszagh
Copy link
Contributor

Simplifies testing CI locally, without modifying the system installation.

@Alexhuszagh Alexhuszagh added the no changelog A valid PR without changelog (no-changelog) label Jun 29, 2022
@Alexhuszagh Alexhuszagh requested a review from a team as a code owner June 29, 2022 15:44
Emilgardis
Emilgardis reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires you to be in workspace root and run the test as ./ci/test.sh

I think that's fine but it'd be nice if it was runnable inside ci/

@Alexhuszagh
Copy link
Contributor Author

this requires you to be in workspace root and run the test as ./ci/test.sh

I think that's fine but it'd be nice if it was runnable inside ci/

I can change it to use bash_source, which will always work then.

@Emilgardis
Copy link
Member

Emilgardis commented Jun 29, 2022 •
edited
Loading

ie. cargo run --bin cross --

also works, but it'll recompile if any flags are changed

nvm, that won't work when moving between folders, source seems good

@Alexhuszagh
Update CI tests to use local cross build.
60326c9 
Simplifies testing CI locally, without modifying the system
installation.
Emilgardis
Emilgardis approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit e594054 into cross-rs:main Jun 29, 2022
@Emilgardis Emilgardis added this to the v0.2.3 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

@otavio otavio Awaiting requested review from otavio

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexhuszagh @Emilgardis