Support dynamically sized types #452
Merged
+367
−140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supersedes #209 for supporting dynamically sized types (DST) in Crossbeam. It's much cleaner and less intrusive than the previous attempts in that it doesn't introduce another
Atomic
type.Atomic<T>
is still there without significant changes.The key idea is (1) instead of requiring the condition on
T: Sized
, (2) requiringT: Pointable
that means an object of typeT
can be pointed to by a single word. For instance,Atomic
becomes:pub struct Atomic<T: ?Sized + Pointable> { ... }
.It is breaking the backward compatibility in that it
(1) increases the minimum required Rust version to 1.36 (fornowMaybeUninit
) and (2)const fn Atomic::null()
is Nightly only.