fix use-after-free in crossbeam-epoch/sync/queue #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop() must completely unlink the popped node from the shared memory before it calls defer_destroy() to prevent use-after-free. This implementation is based on the variation by Doherty et al. where the `head == tail` check is done after a successful CAS, which can be slightly more efficient than the original version. closes crossbeam-rs#238
|
This patch looks good, but I'm not completely sure whether it closes #238. Is it the case that all queues are fixed? |
|
Other queues use their own reclamation methods. |
jeehoonkang
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
LGTM, but I'd like to wait for another +1 (as @tomtomjhj and I are coworking on this patch)
|
I'm merging it, as I think it's better to merge bugfix fast... bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 10, 2020
466: fix use-after-free in crossbeam-epoch/sync/queue r=jeehoonkang a=tomtomjhj `pop()` must completely unlink the popped node from the shared memory before it calls `defer_destroy()` to prevent use-after-free. This implementation is based on the variation by Doherty et al. where the `head == tail` check is done after a successful CAS, which can be slightly more efficient than the original MSQueue. closes #238 Co-authored-by: Jaehwang Jerry Jung <tomtomjhj@gmail.com>
Build succeeded |
This was referenced Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pop()must completely unlink the popped node from the shared memory before it callsdefer_destroy()to prevent use-after-free. This implementation is based on the variation by Doherty et al. where thehead == tailcheck is done after a successful CAS, which can be slightly more efficient than the original MSQueue.closes #238