Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS to CI #642

Closed
wants to merge 1 commit into from
Closed

Add macOS to CI #642

wants to merge 1 commit into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 4, 2021

Currently, 1/4~1/3 tests in crossbeam-channel are ignored due to time-related assertions failed due to GitHub Actions' macOS runner is slow.

@taiki-e taiki-e added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author label Jan 4, 2021
@cynecx
Copy link
Contributor

cynecx commented Jan 4, 2021 •
edited
Loading

Is it possible to add macos-11.0 with the Apple Silicon/M1 as target to the ci? (aka --target aarch64-apple-darwin).

EDIT: Hmm. It may not exactly work because even then we can't run the tests because the environment runs on an x86_64.

EDIT2: But I think it's still worth to add macos-11.0 to the ci.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 4, 2021 •
edited
Loading

@cynecx
I think we can add aarch64-apple-darwin if we can run tests and the environment is stable enough.
However, the current macos-11.0 is still a preview and not stable for GitHub Actions (actions/runner-images#1814).
(I recently tried macos-11.0, but the workflow didn't start.)

@cynecx
Copy link
Contributor

cynecx commented Jan 4, 2021

@taiki-e Sounds like a plan. (Yeh I've noticed the funky availability of macos-11.0 environments too.)

@taiki-e
Copy link
Member Author

taiki-e commented Jan 31, 2021

Seems macos-11.0 is moved to private preview: actions/runner-images#2486

@taiki-e taiki-e force-pushed the macos branch 3 times, most recently from 0eb9c98 to bbbff86 Compare May 29, 2021 11:07
@taiki-e taiki-e mentioned this pull request Jul 23, 2022
Merged
@bors bors bot closed this in 7181f02 Jul 23, 2022
@taiki-e taiki-e deleted the macos branch July 23, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @cynecx