Only call current_thread_id once in try_select #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unclear reason as of writing, calling current_thread_id on each iteration makes Firefox block before displaying a window on aarch64 Linux.
|
This is a duplicate of #802. |
|
@taiki-e Someone contacted you about https://bugzilla.mozilla.org/show_bug.cgi?id=1757571. This is where we are investigation-wise. Applying this patch fixes the issue. That would suggest some kind of race condition somewhere else, but I'm yet to find out the root cause of the problem. The change itself is good to apply anyways. |
|
Heh, I guess I should have checked pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unclear reason as of writing, calling current_thread_id on each
iteration makes Firefox block before displaying a window on aarch64
Linux.